From 091e94e39639b0e5d6434a5162701066b3a86c4f Mon Sep 17 00:00:00 2001
From: Spythere <spythere@protonmail.com>
Date: Thu, 19 Sep 2024 15:48:55 +0200
Subject: [PATCH] fix: vehicle thumbnail names

---
 src/components/Global/StockList.vue        | 37 +++++++------------
 src/components/Global/VehicleThumbnail.vue | 42 ++++++++++++++--------
 2 files changed, 39 insertions(+), 40 deletions(-)

diff --git a/src/components/Global/StockList.vue b/src/components/Global/StockList.vue
index 9534cda..054f38f 100644
--- a/src/components/Global/StockList.vue
+++ b/src/components/Global/StockList.vue
@@ -1,15 +1,13 @@
 <template>
-  <div class="stock-list">
-    <ul>
-      <li v-for="({ images, imagesFallbacks, vehicleString }, i) in thumbnailNames" :key="i">
-        <span>
-          <VehicleThumbnail
-            v-for="(thumbnailImage, imageIndex) in images"
-            :vehicle-string="vehicleString"
-            :img-name="thumbnailImage"
-            :fallback-name="imagesFallbacks[imageIndex]"
-          />
-        </span>
+  <div class="list-wrapper">
+    <ul class="stock-list">
+      <li v-for="({ images, imagesFallbacks, vehicleString }, i) in thumbnailNames">
+        <VehicleThumbnail
+          :key="i"
+          :vehicle-string="vehicleString"
+          :images="images"
+          :image-fallbacks="imagesFallbacks"
+        />
       </li>
     </ul>
   </div>
@@ -148,32 +146,21 @@ export default defineComponent({
           return vehicleThumbnailData;
         });
     }
-  },
-
-  methods: {
-    onImageError(event: Event, fallbackImage: string) {
-      (event.target as HTMLImageElement).src = `/images/${fallbackImage}.png`;
-    }
   }
 });
 </script>
 
 <style lang="scss" scoped>
-.stock-list {
+
+.list-wrapper {
   display: flex;
   justify-content: center;
 }
 
-.stock-list ul {
+.stock-list {
   display: flex;
   align-items: flex-end;
   overflow: auto;
   margin: 0 auto;
 }
-
-ul > li > span {
-  display: flex;
-  align-items: flex-end;
-  cursor: crosshair;
-}
 </style>
diff --git a/src/components/Global/VehicleThumbnail.vue b/src/components/Global/VehicleThumbnail.vue
index 68fad4b..f28c727 100644
--- a/src/components/Global/VehicleThumbnail.vue
+++ b/src/components/Global/VehicleThumbnail.vue
@@ -5,26 +5,28 @@
       <small v-if="vehicleCargo">({{ vehicleCargo }})</small>
     </div>
 
-    <img
-      :src="`https://static.spythere.eu/thumbnails/v2/${imgName}.png`"
-      height="60"
-      loading="lazy"
-      data-tooltip-type="VehiclePreviewTooltip"
-      :data-tooltip-content="vehicleString"
-      @error="onImageError"
-      @load="onImageLoad"
-    />
+    <div class="stock-images">
+      <img
+        v-for="(thumbnailImage, imageIndex) in images"
+        :src="`https://static.spythere.eu/thumbnails/v2/${thumbnailImage}.png`"
+        height="60"
+        loading="lazy"
+        data-tooltip-type="VehiclePreviewTooltip"
+        :data-tooltip-content="vehicleString"
+        @error="onImageError($event, imageFallbacks[imageIndex])"
+        @load="onImageLoad"
+      />
+    </div>
   </div>
 </template>
 
 <script setup lang="ts">
-import { computed, Ref, ref } from 'vue';
+import { computed, PropType, Ref, ref } from 'vue';
 
 const props = defineProps({
   vehicleString: { type: String, required: true },
-  imgName: { type: String, required: true },
-  fallbackName: { type: String, required: true },
-  placeholderName: String
+  images: { type: Object as PropType<string[]>, required: true },
+  imageFallbacks: { type: Object as PropType<string[]>, required: true }
 });
 
 const thumbRef = ref(null) as Ref<HTMLElement | null>;
@@ -33,8 +35,8 @@ const imgStatus = ref('loading');
 const vehicleName = computed(() => props.vehicleString.split(':')[0].replace(/_/g, ' '));
 const vehicleCargo = computed(() => props.vehicleString.split(':')[1]);
 
-function onImageError(event: Event) {
-  (event.target as HTMLImageElement).src = `/images/${props.fallbackName}.png`;
+function onImageError(event: Event, fallbackImage: string) {
+  (event.target as HTMLImageElement).src = `/images/${fallbackImage}.png`;
   imgStatus.value = 'error';
 }
 
@@ -49,6 +51,7 @@ function onImageLoad() {
 
 <style lang="scss" scoped>
 .vehicle-thumbnail {
+  
   position: relative;
   opacity: 0;
   transition: opacity 100ms ease-in-out;
@@ -66,4 +69,13 @@ function onImageLoad() {
   margin-bottom: 0.25em;
   padding: 0.25em 0;
 }
+
+.stock-images {
+  display: flex;
+  justify-content: center;
+  align-items: flex-end;
+  cursor: crosshair;
+
+  padding: 0.5em 0;
+}
 </style>